Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app): fix scrollbar style on LPC results table on ODD #15164

Merged
merged 1 commit into from
May 10, 2024
Merged

fix(app): fix scrollbar style on LPC results table on ODD #15164

merged 1 commit into from
May 10, 2024

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented May 10, 2024 •
edited by jira bot
Loading

closes RQA-2529

Overview

Only show scrollbar if content exceeds container. Style scrollbar to be consistent with other designs.

Test Plan

  1. start a protocol with many labware on ODD
  2. launch and run LPC
  3. verify that offset table content scrollbar is styled according to designs
  4. repeat 1-3 with a protocol with few labware and verify that no scrollbar renders

Changelog

  • style y overflow on ResultsSummary of LPC

Review requests

@koji per testing

Risk assessment

low

@ncdiehl11
fix(app): fix scrollbar style on LPC results table on ODD
81ceb99 
Only show scrollbar if content exceeds container. Style scrollbar to be consistent with other
designs.
@ncdiehl11 ncdiehl11 self-assigned this May 10, 2024
@ncdiehl11 ncdiehl11 requested a review from koji May 10, 2024 19:21
@ncdiehl11 ncdiehl11 marked this pull request as ready for review May 10, 2024 19:28
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner May 10, 2024 19:28
koji
koji approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ncdiehl11 ncdiehl11 merged commit ed09d54 into chore_release-7.3.0 May 10, 2024
26 checks passed
@ncdiehl11 ncdiehl11 deleted the fix_app-odd-lpc-results-scroll branch May 10, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koji koji koji approved these changes

Assignees

@ncdiehl11 ncdiehl11

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ncdiehl11 @koji